Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security group updates #43

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Security group updates #43

merged 13 commits into from
Feb 10, 2022

Conversation

danjbh
Copy link
Contributor

@danjbh danjbh commented Feb 3, 2022 •
edited by Nuru
Loading

NOTE: The work in this PR mirrors the security group updates performed in cloudposse/terraform-aws-elasticache-redis#133, since these modules are very similar.

what

  • Upgrade to new Cloud Posse security group standards
  • Enable create_before_destroy on security groups by default
  • Update AWS provider version constraint to properly require a version that has all the features the module uses
  • Add security group ARN and name to outputs.tf

why

  • Further standardize all Cloud Posse modules
  • Supply bug fixes and features requested via "issues".

@danjbh danjbh marked this pull request as ready for review February 3, 2022 22:18
@danjbh danjbh requested review from a team as code owners February 3, 2022 22:18
@danjbh
Copy link
Contributor Author

danjbh commented Feb 3, 2022

/test all

@danjbh
Copy link
Contributor Author

danjbh commented Feb 3, 2022

/test all

@nitrocode
Copy link
Member

Is the security group inputs the latest export from the sg module?

Were you able to upgrade an existing customer to this prs module?

Could you include a migration guide like we did in previous modules that updated to sh 4.x?

@Nuru Nuru mentioned this pull request Feb 10, 2022
Closed
1 task
@Nuru
Copy link

Nuru commented Feb 10, 2022

/test all

@Nuru Nuru added the enhancement New feature or request label Feb 10, 2022
@Nuru Nuru merged commit 92be854 into master Feb 10, 2022
@Nuru Nuru deleted the security-group-updates branch February 10, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@Nuru Nuru Nuru approved these changes

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjbh @nitrocode @Nuru @cloudpossebot