Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aws provider v5 and newer TF #62

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Add support for aws provider v5 and newer TF #62

merged 2 commits into from
Jul 17, 2023

Conversation

MaxymVlasov
Copy link
Contributor

Plus fixes from

make init
make github/init
make readme

@MaxymVlasov @vladget
Add support for aws provider v5
02b42f4 
Co-authored-by: vladget <vladget@users.noreply.github.com>
@MaxymVlasov MaxymVlasov requested review from a team as code owners July 17, 2023 13:21
@MaxymVlasov MaxymVlasov changed the title Add support for aws provider v5 Add support for aws provider v5 and for_each Jul 17, 2023
@MaxymVlasov MaxymVlasov changed the title Add support for aws provider v5 and for_each Add support for aws provider v5 and ability ti use module with for_each Jul 17, 2023
@MaxymVlasov MaxymVlasov changed the title Add support for aws provider v5 and ability ti use module with for_each Add support for aws provider v5 and newer TF Jul 17, 2023
@aknysh
Copy link
Member

aknysh commented Jul 17, 2023

@MaxymVlasov thank you for the PR.

Please also update:

https://github.com/cloudposse/terraform-aws-elasticache-memcached/blob/main/examples/complete/versions.tf

https://github.com/cloudposse/terraform-aws-elasticache-memcached/blob/main/examples/complete/main.tf - here use the latest versions of the VPC and subnets module, see https://github.com/cloudposse/terraform-aws-eks-cluster/blob/main/examples/complete/main.tf as an example (nite that some attributes are different, see the EKS example)

Thank you

aknysh
aknysh reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to update the example as well, thanks

@MaxymVlasov MaxymVlasov requested a review from aknysh July 17, 2023 14:26
@aknysh
Copy link
Member

aknysh commented Jul 17, 2023

/terratest

aknysh
aknysh approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MaxymVlasov

@aknysh aknysh merged commit 3af858d into cloudposse:main Jul 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxymVlasov @aknysh