Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom enpoint configuration #105

Merged
merged 3 commits into from
Apr 12, 2021
Merged

feat: support custom enpoint configuration #105

merged 3 commits into from
Apr 12, 2021

Conversation

gberenice
Copy link
Contributor

what

  • Adds support for ES custom endpoints since it was shipped in provider in v0.35

why

  • This helps to get rid of workaround like using null_resource to enable custom endpoint

references

@gberenice gberenice requested review from a team as code owners April 12, 2021 15:47
@gberenice gberenice requested a review from a team as a code owner April 12, 2021 15:47
Gowiem
Gowiem previously approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

versions.tf
@@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 2.0"
version = ">= 3.35.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@Gowiem
Copy link
Member

Gowiem commented Apr 12, 2021

/test all

@mergify mergify bot dismissed Gowiem’s stale review April 12, 2021 16:04

This Pull Request has been updated, so we're dismissing all reviews.

@Gowiem
Copy link
Member

Gowiem commented Apr 12, 2021

/test all

@Gowiem Gowiem merged commit 0541281 into cloudposse:master Apr 12, 2021
@Gowiem
Copy link
Member

Gowiem commented Apr 12, 2021

Thanks for the contribution @gberenice! Released as 0.31.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gberenice @Gowiem @cloudpossebot