fix when awareness is disabled, always changing #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
nitrocode
reviewed
Jan 17, 2022
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_60 Fixed /main.tf aws_db_instance.default BC_AWS_LOGGING_28 Fixed /main.tf aws_db_instance.default
|
/test all |
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_60 Fixed /main.tf aws_db_instance.default BC_AWS_LOGGING_28 Fixed /main.tf aws_db_instance.default
Gowiem
approved these changes
Feb 15, 2022
|
@sanarena Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-elasticsearch/releases/tag/0.35.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
When we disable zone awareness, Terraform want to put in availability_zone_count on every single run,
so resource is always marked as changed.
This pull request fix this issue.
why
Avoid unnecessary AWS calls and changes.