Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other AWS partitions #43

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Add support for other AWS partitions #43

merged 2 commits into from
Aug 14, 2021

Conversation

epf
Copy link
Contributor

@epf epf commented Jul 30, 2021

what

  • Add support for other AWS partitions (China, GovCloud)

why

  • AWS China and AWS GovCloud exist
  • arn:aws: should never be hardcoded because of this

@epf epf requested review from a team as code owners July 30, 2021 06:36
@epf epf requested a review from a team as a code owner July 30, 2021 06:36
@epf epf requested review from srhopkins and joe-niland and removed request for a team July 30, 2021 06:36
@nitrocode
Copy link
Member

/test all

@epf
Copy link
Contributor Author

epf commented Aug 13, 2021

Can we please merge this?

@nitrocode nitrocode merged commit a418f45 into cloudposse:master Aug 14, 2021
@nitrocode
Copy link
Member

@epf thanks for the bump and the pull request! It's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants