Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS Provider V5 #159

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Support AWS Provider V5 #159

merged 6 commits into from
Nov 13, 2023

Conversation

max-lobur
Copy link
Contributor

@max-lobur max-lobur commented Jun 7, 2023 •
edited
Loading

what

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 7, 2023
@max-lobur max-lobur requested review from a team as code owners June 7, 2023 17:01
bridgecrew[bot]
bridgecrew bot reviewed Jun 7, 2023
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@tmeijn
Copy link

tmeijn commented Jul 20, 2023

Note: for v5 upgrade identifier needs to be exposed: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-5-upgrade#aws_db_instanceid-is-no-longer-the-identifier

@mihaiplesa
Copy link
Contributor

@max-lobur has this one been abandoned?

bridgecrew[bot]
bridgecrew bot reviewed Nov 10, 2023
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Nov 10, 2023
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Nov 10, 2023
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Nov 10, 2023
View reviewed changes
main.tf Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

No I just didn't have time to merge all of these. I will fix today

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur added major Breaking changes (or first stable release) and removed no-release Do not create a new release (wait for additional code changes) labels Nov 11, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur enabled auto-merge (squash) November 13, 2023 15:14
@max-lobur max-lobur merged commit 9d720ec into main Nov 13, 2023
10 of 11 checks passed
@max-lobur max-lobur deleted the aws_v5 branch November 13, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@milldr milldr milldr approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-lobur @tmeijn @mihaiplesa @milldr