Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restore_to_point_in_time variable #165

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Add restore_to_point_in_time variable #165

merged 5 commits into from
Nov 16, 2023

Conversation

joe-niland
Copy link
Member

what

  • Allow specifying the required configuration to create a database instance via the point-in-time-recovery process
  • Update variable description for snapshot_identifier

why

  • Support an alternative creation/DR scenario

references

None

@joe-niland joe-niland requested review from a team as code owners November 16, 2023 06:16
Gowiem
Gowiem requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to fail tests so change the readme provider issue and we'll get this shipped! 👍

docs/terraform.md Outdated Show resolved Hide resolved
@joe-niland
Copy link
Member Author

/terratest

Gowiem
Gowiem approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joe-niland joe-niland merged commit b382b21 into cloudposse:main Nov 16, 2023
10 checks passed
@joe-niland joe-niland deleted the feat/restore-to-point-in-time branch November 16, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-niland @Gowiem