More accurate control of create before destroy behaviors #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
added
wip
|
/test all |
|
/test all |
|
/test all |
aknysh
reviewed
Jun 25, 2022
|
/test all |
|
/test all |
|
/test all |
aknysh
reviewed
Jul 7, 2022
aknysh
reviewed
Jul 7, 2022
| This is particularly important because a security group cannot be destroyed while it is associated with | ||
| a resource (e.g. a load balancer), but "destroy before create" behavior causes Terraform | ||
| to try to destroy the security group before disassociating it from associated resources, | ||
| so plans fail to apply with the error |
There was a problem hiding this comment.
Suggested change
| so plans fail to apply with the error | |
| so plans fail with the error |
There was a problem hiding this comment.
The Terraform successfully creates the plan, but the plan fails to apply.
aknysh
reviewed
Jul 7, 2022
aknysh
reviewed
Jul 7, 2022
aknysh
reviewed
Jul 7, 2022
aknysh
reviewed
Jul 7, 2022
aknysh
reviewed
Jul 7, 2022
osterman
previously approved these changes
Jul 7, 2022
|
Great depiction of the problem at a high-level. This is a great addition to the README. |
Nuru
added
the
no-release
|
/test all |
aknysh
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
README and code are (hopefully) final.
This will be released as v2.0.0-rc1 due to changed defaults, requirement for Terraform 1.0, and possible service interruption when upgrading. Migration document TBD.
what
create_before_destroydefault totruefor security groupspreserve_security_group_idto control replacement of security group when rules changewhy
create_before_destroy = falsewill fail with an error because you cannot destroy a security group while it is associated with a resourcereferences