Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document migration from v1 to v2 #42

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Document migration from v1 to v2 #42

merged 3 commits into from
Dec 9, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Dec 9, 2022

what

why

  • Serious issues exist in v1, causing v2 to have different defaults and new settings. Documentation is needed to guide users on how to upgrade while minimizing service interruptions.

references

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Dec 9, 2022
@Nuru Nuru requested review from a team as code owners December 9, 2022 07:19
@Nuru
Copy link
Contributor Author

Nuru commented Dec 9, 2022

/test all

aknysh
aknysh reviewed Dec 9, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
aknysh
aknysh previously approved these changes Dec 9, 2022
View reviewed changes
@Nuru Nuru requested a review from aknysh December 9, 2022 19:08
@Nuru
Copy link
Contributor Author

Nuru commented Dec 9, 2022

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Dec 9, 2022

/test all

@Nuru Nuru merged commit a1b4b2d into master Dec 9, 2022
@Nuru Nuru deleted the v2-release branch December 9, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem

@joe-niland joe-niland Awaiting requested review from joe-niland

@osterman osterman Awaiting requested review from osterman

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enabled = false fails with "The given key does not identify an element in this collection value."
2 participants
@Nuru @aknysh