Update DenyEC2InstancesWithoutEncryptionInTransit #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
previously approved these changes
Sep 26, 2022
|
/test all |
|
/test all |
aknysh
approved these changes
Sep 27, 2022
mcalhoun
reviewed
Sep 27, 2022
Comment on lines
+77
to
+85
| # updated 2022-09-26 | ||
| - c5a.12xlarge | ||
| - c5a.16xlarge | ||
| - c5a.24xlarge | ||
| - c5a.2xlarge | ||
| - c5a.4xlarge | ||
| - c5a.8xlarge | ||
| - c5a.large | ||
| - c5a.xlarge |
There was a problem hiding this comment.
Is there a reason you updated these to the specific instance types rather than the wildcard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
DenyEC2InstancesWithoutEncryptionInTransitpolicy with current list of instancesDenyS3InNonSelectedRegionpolicyDenyRegionUsagepolicy withDenyRegionsandRestrictToSpecifiedRegionspolicieswhy
c6i,c7g, andg5to name a fewcatalog/*.yamlwithout needing to specify any parametersDenyS3InNonSelectedRegionpolicy was completely broken, having no effectDenyRegionUsagepolicy was confusing, because it took a parameter calledregions_lockdownwhich was a list of regions to allow. The new policies let you choose to either whitelist or blacklist regions.references