Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map mismatch #31

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix map mismatch #31

merged 1 commit into from
Sep 12, 2022

Conversation

cvlc
Copy link
Contributor

@cvlc cvlc commented Sep 12, 2022

what

  • Fixed failures in the module due to a mismatch in the maps.

why

  • Currently the module does not work. This resolved the issue.

references

errata

It would probably also be helpful to have a note in README.md about the need for policies to exist in the target account to be associated. The provided example is a little misleading for that reason.

@cvlc cvlc requested review from a team as code owners September 12, 2022 12:51
@nitrocode nitrocode added the patch A minor, backward compatible change label Sep 12, 2022
@nitrocode
Copy link
Member

nitrocode commented Sep 12, 2022

@lawliet89 is the previous contributor to 0.7.0. @lawliet89 can you confirm this fix is correct?

For now, I set 0.7.0 release as a pre-release until this PR is resolved.

@nitrocode nitrocode merged commit 5c8a95d into cloudposse:master Sep 12, 2022
@lawliet89
Copy link
Contributor

lawliet89 commented Sep 13, 2022

Yes. Sorry, that was a mistake on my part.

@nitrocode
Copy link
Member

np, all fixed now :)

@cvlc cvlc deleted the patch-1 branch September 13, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants