Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSO module #41

Closed
wants to merge 2 commits into from
Closed

Fix SSO module #41

wants to merge 2 commits into from

Conversation

jagnk
Copy link

@jagnk jagnk commented May 26, 2023

what

Fix the deprecation warnings as described here: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v4.40.0 for module.sso_account_assignments.data.aws_identitystore_user.this

why

Otherwise there are deprecation error described in issue #38

references

@jagnk jagnk requested review from a team as code owners May 26, 2023 13:35
@Gowiem
Copy link
Member

Gowiem commented May 26, 2023

@jagnk can you also bump the require AWS provider to >= 4.40.0 since that will now be required if we're going to use this new argument?

@Gowiem Gowiem added the patch A minor, backward compatible change label May 26, 2023
Co-authored-by: Matt Gowie  <matt@masterpoint.io>
@jagnk
Copy link
Author

jagnk commented Jun 7, 2023

I am using latest AWS provider and still having this issue

Initializing provider plugins...
- Finding latest version of hashicorp/null...
- Finding hashicorp/aws versions matching ">= 4.30.0, >= 4.40.0"...
- Installing hashicorp/null v3.2.1...
- Installed hashicorp/null v3.2.1 (signed by HashiCorp)
- Installing hashicorp/aws v5.0.0...
- Installed hashicorp/aws v5.0.0 (signed by HashiCorp)

@Benbentwo
Copy link
Member

Hey @jagnk thanks for your PR here, I've duplicated the fixes on this module, I've moved the changes over to #44 as I'm updating the workflows too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants