Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README example #9

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Fix README example #9

merged 3 commits into from
Jun 4, 2021

Conversation

nitrocode
Copy link
Member

what

  • Standardized module reference source (old one didn't work due to lack of git:: prefix)
  • Removed additional closing square bracket
  • Converted missing var.shorten_regions reference to local and created local

why

  • Broken example

references

N/A

@nitrocode nitrocode requested review from a team as code owners May 26, 2021 16:52
@nitrocode nitrocode requested a review from a team as a code owner May 26, 2021 16:52
@nitrocode nitrocode requested review from Makeshift and 3h4x May 26, 2021 16:52
@mergify
Copy link

mergify bot commented Jun 2, 2021

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

osterman
osterman previously approved these changes Jun 2, 2021
View reviewed changes
@nitrocode nitrocode requested a review from osterman June 2, 2021 15:29
@nitrocode nitrocode merged commit 399951e into master Jun 4, 2021
@nitrocode nitrocode deleted the fix-readme-example branch June 4, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@3h4x 3h4x Awaiting requested review from 3h4x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @osterman @cloudpossebot