Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused and deprecated template provider #37

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Remove unused and deprecated template provider #37

merged 2 commits into from
Jan 20, 2022

Conversation

sapslaj
Copy link
Contributor

@sapslaj sapslaj commented Jan 20, 2022

what

  • Removes the template provider from required_providers

why

  • The template provider is deprecated by Hashicorp.
  • Said provider appears to be unused in this module (it works perfectly fine without it).
  • Trying to run Terraform on an M1 Mac with this module results in an error since the template provider does not have a darwin_arm64 build.

references

@sapslaj sapslaj requested review from a team as code owners January 20, 2022 01:15
@sapslaj sapslaj requested a review from a team as a code owner January 20, 2022 01:16
@sapslaj sapslaj requested review from jamengual and max-lobur and removed request for a team January 20, 2022 01:16
@aknysh
Copy link
Member

aknysh commented Jan 20, 2022

/test all

aknysh
aknysh approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sapslaj

@aknysh aknysh added the patch A minor, backward compatible change label Jan 20, 2022
@aknysh aknysh merged commit 0960878 into cloudposse:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@max-lobur max-lobur Awaiting requested review from max-lobur max-lobur was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapslaj @aknysh @cloudpossebot