-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/ignore cidr blocks #43
Conversation
/test all |
@colinh6 thank you for the PR, looks good, but please fix these errors https://github.com/cloudposse/actions/actions/runs/3325626731/jobs/5498510030 |
ed080bc
to
b95e170
Compare
@aknysh Thank you for the review, I believe my latest commit should (hopefully) fix the errors. Could you please re-run the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
@aknysh I believe I have fixed that error. I have attempted to run terratest locally but am having a number of issues. Would you mind re-running the tests again for me? Much appreciated. |
/test all |
911b5cf
to
91fc93a
Compare
@aknysh I found some time and got the tests running locally, I have them passing now. Could you check again for me? |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colinh6 thanks again, please see the comments (please fix the error in terratest)
/test all |
what
why
100.64.0.0/16
to each of our EKS cluster VPCs to increase the maximum amount of assignable IP addresses when using the AWS VPC CNI.100.64.0.0/16
routes will conflict in certain cases.database
orelasticsearch
VPC to multiple different EKS cluster VPCs that all contain the100.64.0.0/16
additional CIDR associationreferences