Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output description #113

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Fix output description #113

merged 4 commits into from
Oct 28, 2022

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Oct 27, 2022 •
edited by joe-niland
Loading

what

  • IPv6 related description typo fix

why

  • In IPv6 related outputs vars description contains IPv4 instead of IPv6

@ngoyal16 ngoyal16 requested review from a team as code owners October 27, 2022 07:48
@ngoyal16 ngoyal16 requested review from dotCipher and woz5999 and removed request for a team October 27, 2022 07:48
@joe-niland
Copy link
Member

Hi @ngoyal16 could you please fill out the PR template and also make your changes in outputs.tf? The docs are auto-generated.

@ngoyal16
Copy link
Contributor Author

@joe-niland i have updated MR template also update the changes in output.tf

@joe-niland joe-niland changed the title Fix output descritpion Fix output description Oct 28, 2022
@joe-niland
Copy link
Member

/test all

@joe-niland joe-niland added the patch A minor, backward compatible change label Oct 28, 2022
@ngoyal16
Copy link
Contributor Author

@joe-niland when this can be merged

@joe-niland joe-niland merged commit 3e61cf9 into cloudposse:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngoyal16 @joe-niland @cloudpossebot