Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthetics): Adjust timeframes loop to include child objects #107

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

elx-bob
Copy link
Contributor

@elx-bob elx-bob commented Oct 21, 2024

what

  • Change loop to use child objects instead of timeframes object.
  • Update Datadog provider requirements for synthetics
  • Fix broken test

why

  • Synthetics options.scheduling.timeframes was incorrectly treated as an object, and is now correctly treated as a list of objects, as specified in the API documentation
  • Improved API validation at the server level uncovered a bug in the Datadog provider for synthetic tests, which was fixed in provider v3.43.1
  • The test requirement that the monitor had no tags was overly strict, requiring a nil output rather than an empty one, causing properly working code to be marked as failing

references

@elx-bob elx-bob requested review from a team as code owners October 21, 2024 21:15
@mergify mergify bot added the triage Needs triage label Oct 21, 2024
@RoseSecurity
Copy link

/terratest

@GabisCampana
Copy link

@Nuru

@Nuru Nuru added bugfix Change that restores intended behavior and removed triage Needs triage labels Oct 24, 2024
Nuru
Nuru previously approved these changes Oct 24, 2024
@Nuru
Copy link
Contributor

Nuru commented Oct 24, 2024

/terratest

@Nuru Nuru enabled auto-merge (squash) October 24, 2024 23:55
@Nuru
Copy link
Contributor

Nuru commented Oct 25, 2024

/terratest

@Nuru Nuru disabled auto-merge October 25, 2024 01:03
@Nuru
Copy link
Contributor

Nuru commented Oct 25, 2024

@elx-bob Thank you for this PR.

At the moment, the automated tests are failing. The test failures do not appear to be related to this PR, but still, we do not like to accept/merge PRs when the tests are failing. I am looking into it; no further action is required on your part at this time.

@Nuru
Copy link
Contributor

Nuru commented Oct 25, 2024

/terratest

@Nuru Nuru self-requested a review October 25, 2024 07:49
@Nuru Nuru merged commit c04a852 into cloudposse:main Oct 25, 2024
28 checks passed
Copy link

These changes were released in v1.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
4 participants