Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Locations Support #55

Merged
merged 11 commits into from
Dec 3, 2021
Merged

Public Locations Support #55

merged 11 commits into from
Dec 3, 2021

Conversation

Benbentwo
Copy link
Member

what

  • Adding a var for public locations that includes ["all"] support to enable all (currently) supported DD locations

why

  • if not using private locations we should enable passing ["aws:my-region"] or ["all"]

@Benbentwo Benbentwo requested a review from aknysh December 2, 2021 19:54
@Benbentwo Benbentwo requested review from a team as code owners December 2, 2021 19:54
@Benbentwo Benbentwo requested a review from jhosteny December 2, 2021 19:54
@Benbentwo
Copy link
Member Author

/test all

aknysh
aknysh previously requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@mergify mergify bot dismissed aknysh’s stale review December 2, 2021 20:13

This Pull Request has been updated, so we're dismissing all reviews.

@Benbentwo
Copy link
Member Author

/test all

@Benbentwo
Copy link
Member Author

/test all

aknysh
aknysh reviewed Dec 3, 2021
View reviewed changes
modules/synthetics/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Dec 3, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@Benbentwo
Copy link
Member Author

/test all

@Benbentwo Benbentwo merged commit 95eb214 into master Dec 3, 2021
@Benbentwo Benbentwo deleted the default-locations branch December 3, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@aknysh aknysh aknysh approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Benbentwo @aknysh @nitrocode @cloudpossebot