Feature/enabled monitors #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
/test all |
nitrocode
reviewed
Feb 10, 2022
|
/test all |
|
/test all |
nitrocode
reviewed
Feb 11, 2022
aknysh
reviewed
Feb 11, 2022
| @@ -6,7 +6,7 @@ locals { | |||
|
|
|||
| # https://registry.terraform.io/providers/DataDog/datadog/latest/docs/resources/monitor | |||
| resource "datadog_monitor" "default" { | |||
| for_each = local.enabled ? var.datadog_monitors : {} | |||
| for_each = local.enabled ? { for k, v in var.datadog_monitors : k => v if lookup(v, "enabled", true) } : {} | |||
There was a problem hiding this comment.
did you try it with module.this.enabled = false.
In some cases, Tf complains about both side of the ? operator not having the same types of elements.
If that's an issue, we can do
for_each = { for k, v in var.datadog_monitors : k => v if local.enabled && lookup(v, "enabled", true) }
There was a problem hiding this comment.
TF complained about it in the component for merging the yaml, but not in the module. Figured out an adjustment to some of the component for_each's to get it to work.
aknysh
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why