Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a valid default for timeout_h #64

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Use a valid default for timeout_h #64

merged 2 commits into from
Jun 14, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 14, 2022 •
edited
Loading

what

  • Use a valid default for timeout_h

why

  • Fixes datadog's deprecation of timeout_h greater than 24
  • Reason why 0 was chosen is because for some monitors 0 is already used

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 14, 2022
@nitrocode nitrocode requested review from a team as code owners June 14, 2022 18:29
@nitrocode nitrocode requested review from jhosteny and RothAndrew June 14, 2022 18:29
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 4b9c8d1 into master Jun 14, 2022
@nitrocode nitrocode deleted the fix-timeout_h branch June 14, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeout_h api change to enforce validation
3 participants
@nitrocode @aknysh @cloudpossebot