Enhance synthetics to accept Datadog API output of test definitions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
requested review from
johncblandii,
korenyoni,
bradj,
aknysh,
milldr and
Benbentwo
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
|
/terratest |
|
/terratest |
aknysh
reviewed
Oct 23, 2023
|
/terratest |
milldr
approved these changes
Oct 23, 2023
Comment on lines
+17
to
+18
| (Note that some items in the response are read-only, and are ignored if included | ||
| in the definition of a test.) There are errors and omissions in the documentation |
There was a problem hiding this comment.
Suggested change
| (Note that some items in the response are read-only, and are ignored if included | |
| in the definition of a test.) There are errors and omissions in the documentation | |
| (Note that some items in the response are read-only and are ignored if included | |
| in the definition of a test.) There are errors and omissions in the documentation |
Comment on lines
+30
to
+31
| This is a known issue with Datadog, and hopefully will be fixed soon, but verify that it is fixed before | ||
| relying on the list of all tests if you are using multistep browser tests. |
There was a problem hiding this comment.
Suggested change
| This is a known issue with Datadog, and hopefully will be fixed soon, but verify that it is fixed before | |
| relying on the list of all tests if you are using multistep browser tests. | |
| This is a known issue with Datadog and hopefully will be fixed soon, but verify that it is fixed before | |
| relying on the list of all tests if you are using multistep browser tests. |
|
|
||
| variable "default_tags_enabled" { | ||
| type = bool | ||
| description = "If true, all tests will have tags from `null-label` added to them" |
There was a problem hiding this comment.
Suggested change
| description = "If true, all tests will have tags from `null-label` added to them" | |
| description = "If `true`, all tests will have tags from `null-label` added to them" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
syntheticsmodule:null-labeltags optionalwhy
references