Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions.tf to support tf .14 #105

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Update versions.tf to support tf .14 #105

merged 3 commits into from
Nov 10, 2020

Conversation

kiddom-kq
Copy link
Contributor

@kiddom-kq kiddom-kq commented Nov 10, 2020

Adds support for Terraform 0..14 (currently in beta2)

I've currently got it pinned to < 0.14.1 to be conservative. Can update to < 0.15 or similar.

what

  • Bumps versions.tf to support terraform 0.14

why

  • I make extensive use of this label module (it's an amazing contribution to the TF ecosystem. Thank you!)
  • I am currently running into an unrelated issue w/ TF 0.13. The proposed workaround for that unrelated issue does not work for me at this time.
  • The solution is to use tf 0.14 which is in beta, now.

references

Fixes #104

Adds support for Terraform `0..14` (currently in `beta2`)
@kiddom-kq kiddom-kq requested a review from a team as a code owner November 10, 2020 21:34
versions.tf Outdated Show resolved Hide resolved
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@kiddom-kq
Copy link
Contributor Author

Thanks for the super fast turn around!

Glad to see you're no longer using ceilings for versions. i'll have an updated commit in a moment.

@aknysh
Copy link
Member

aknysh commented Nov 10, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Nov 10, 2020

/test all

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kiddom-kq

@aknysh aknysh merged commit 0489417 into cloudposse:master Nov 10, 2020
@Nuru
Copy link
Contributor

Nuru commented Nov 11, 2020

@aknysh Any changes to null-label should include an update to context.tf to use the new version and its new functionality (if any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TF 0.14
3 participants