Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add var.attributes to end of context.attributes, not vice versa #114

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Add var.attributes to end of context.attributes, not vice versa #114

merged 3 commits into from
Dec 22, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Dec 22, 2020

what

  • Add var.attributes to end of context.attributes, not vice versa
  • Update to current workflows (with some exceptions)

why

  • Modules should append to attributes passed in, not insert themselves ahead of others
  • New features, like auto-format (but holding back some, because this is a special module)

references

@Nuru Nuru requested a review from a team as a code owner December 22, 2020 00:27
@Nuru
Copy link
Contributor Author

Nuru commented Dec 22, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Dec 22, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Dec 22, 2020

/test bats

@Nuru Nuru merged commit f145d2a into master Dec 22, 2020
@Nuru Nuru deleted the attribute-order branch December 22, 2020 01:51
@Xerkus Xerkus mentioned this pull request May 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change order of attribute concatination Empty ID
2 participants
@Nuru @osterman