Use enabled in all modules
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
enabledin all moduleswhy
enabledflag to enable/disable all sub-modulesremote-statethrows errors whenenabled=falseand it tries to load YAML config filesinventory of problems (internal notes)
in 0.10.0, if you set
enabled=false, then the backend module will not get the environment or stage, so it won't find the right stack and will error that i cannot find the stack. So in 0.11.0 we now setcount=0whenenabled=falseon data resources. This would happen during aterraform applywhenenabled=falsefor some module that depended onremote-stateand/orbackend, becausecountwas not respected.0.11.0 we have counts on the data sources, but this is now causing the "count of cannot be computed" type of problems anywhere we use the output of the remote state as an input put to another module that performs a count on that input (nested counts). Historically, counts on data sources has been problematic.
components need to work with remote state all returning null (which most of them don't), or disabling them does not remove the requirement that the remote state exists.