Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for Terraform Cloud #57

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Restore support for Terraform Cloud #57

merged 2 commits into from
Oct 18, 2022

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 17, 2022

what

why

  • Restore temporarily disabled feature

@Nuru Nuru requested review from osterman and aknysh October 17, 2022 03:31
@Nuru Nuru requested review from a team as code owners October 17, 2022 03:31
@Nuru Nuru requested review from dotCipher and korenyoni October 17, 2022 03:31
@Nuru
Copy link
Contributor Author

Nuru commented Oct 17, 2022

/test all

@Nuru Nuru added the minor New features that do not break anything label Oct 17, 2022
@Nuru Nuru enabled auto-merge (squash) October 17, 2022 03:47
aknysh
aknysh reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nitpicks

@Nuru @aknysh
Apply suggestions from code review
702147a 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@Nuru Nuru requested a review from aknysh October 18, 2022 04:51
@Nuru
Copy link
Contributor Author

Nuru commented Oct 18, 2022

Note that the nitpicks were just copied verbatim from the previous s3.tf, but I agree with the fixes and changed them.

@Nuru
Copy link
Contributor Author

Nuru commented Oct 18, 2022

/test all

@Nuru Nuru merged commit a7e87a4 into main Oct 18, 2022
Nuru added a commit that referenced this pull request Oct 18, 2022
@Nuru
Fix bug introduced in #57
2dd70ce
@Nuru Nuru mentioned this pull request Oct 18, 2022
Merged
Nuru added a commit that referenced this pull request Oct 18, 2022
@Nuru
Fix bug introduced in v1.3.0 by #57 (#58)
3c7ac8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@osterman osterman Awaiting requested review from osterman

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh