Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "cloudposse/utils" provider versions. Update GitHub workflows #64

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Update "cloudposse/utils" provider versions. Update GitHub workflows #64

merged 4 commits into from
Apr 27, 2023

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Apr 27, 2023 •
edited by Nuru
Loading

what

  • Update cloudposse/utils provider versions
  • Update GitHub workflows

why

references

Supersedes and close #63

@aknysh aknysh requested a review from Nuru April 27, 2023 21:45
@aknysh aknysh self-assigned this Apr 27, 2023
@aknysh aknysh requested review from a team as code owners April 27, 2023 21:45
@aknysh aknysh requested review from jamengual and woz5999 April 27, 2023 21:45
@aknysh
Copy link
Member Author

aknysh commented Apr 27, 2023

/test all

@Nuru Nuru added the patch A minor, backward compatible change label Apr 27, 2023
Nuru
Nuru previously approved these changes Apr 27, 2023
View reviewed changes
@Nuru Nuru dismissed their stale review April 27, 2023 21:53

Didn't see version pin

@aknysh
Copy link
Member Author

aknysh commented Apr 27, 2023

/test all

@aknysh aknysh requested a review from Nuru April 27, 2023 21:58
Nuru
Nuru requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to update the versions in the tests, OK, but I see no reason for or benefit in updating the required provider versions in the modules. 1.7.1 works fine, 1.8.0 does not add any features they need, so we should let people continue to use it.

modules/backend/versions.tf Outdated Show resolved Hide resolved
modules/env/versions.tf Outdated Show resolved Hide resolved
modules/settings/versions.tf Outdated Show resolved Hide resolved
modules/spacelift/versions.tf Outdated Show resolved Hide resolved
modules/vars/versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
aknysh and others added 2 commits April 27, 2023 18:12
@aknysh @Nuru
Apply suggestions from code review
87539fa 
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
@cloudpossebot
Auto Format
6aaaf14
@aknysh
Copy link
Member Author

aknysh commented Apr 27, 2023

If you want to update the versions in the tests, OK, but I see no reason for or benefit in updating the required provider versions in the modules. 1.7.1 works fine, 1.8.0 does not add any features they need, so we should let people continue to use it.

I agree, but I thought we update everything to the last version so everything is easier to manage

@aknysh
Copy link
Member Author

aknysh commented Apr 27, 2023

/test all

@aknysh aknysh requested a review from Nuru April 27, 2023 22:18
@aknysh aknysh merged commit 8647952 into main Apr 27, 2023
@aknysh aknysh deleted the update-utils-provider-2 branch April 27, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknysh @Nuru @cloudpossebot