rm extra retain

cloudquery · Jun 3, 2023 · 579ffea · 579ffea
1 parent 56ba3cf
commit 579ffea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/csv/read.go b/csv/read.go
@@ -24,7 +24,6 @@ func (cl *Client) Read(r io.Reader, table *schema.Table, _ string, res chan<- ar
 			return reader.Err()
 		}
 		rec := reader.Record()
-		rec.Retain()
 		castRec, err := castFromString(rec, arrowSchema)
 		if err != nil {
 			return fmt.Errorf("failed to cast extension types: %w", err)

diff --git a/parquet/read.go b/parquet/read.go
@@ -8,18 +8,13 @@ import (
 	"github.com/apache/arrow/go/v13/arrow"
 	"github.com/apache/arrow/go/v13/arrow/array"
 	"github.com/apache/arrow/go/v13/arrow/memory"
+	"github.com/apache/arrow/go/v13/parquet"
 	"github.com/apache/arrow/go/v13/parquet/file"
 	"github.com/apache/arrow/go/v13/parquet/pqarrow"
 	"github.com/cloudquery/plugin-sdk/v3/schema"
 )
 
-type ReaderAtSeeker interface {
-	io.Reader
-	io.ReaderAt
-	io.Seeker
-}
-
-func (*Client) Read(f ReaderAtSeeker, table *schema.Table, _ string, res chan<- arrow.Record) error {
+func (*Client) Read(f parquet.ReaderAtSeeker, table *schema.Table, _ string, res chan<- arrow.Record) error {
 	ctx := context.Background()
 	rdr, err := file.NewParquetReader(f)
 	if err != nil {