-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add opts.SchedulerOpts()
helper to convert plugin.SyncOptions
for scheduler
#1900
Conversation
plugin/plugin_source.go
Outdated
@@ -6,6 +6,7 @@ import ( | |||
|
|||
"github.com/cloudquery/plugin-sdk/v4/glob" | |||
"github.com/cloudquery/plugin-sdk/v4/message" | |||
"github.com/cloudquery/plugin-sdk/v4/scheduler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if it's worth the extra import. This is the only line in the plugin
package to refer to scheduler
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can put this here https://github.com/cloudquery/plugin-sdk/tree/main/helpers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheduler
already imports helpers
(DFS uses helpers.InterfaceSlice()
so it has to be a separate package. opts
package, func SchedulerOpts()
? (done in 77daaf3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to git add
, sorry fixed in 4d699f5
SchedulerOptions()
helper method to plugin.SyncOptions
opts.SchedulerOpts()
helper method to convert plugin.SyncOptions
for scheduler
opts.SchedulerOpts()
helper method to convert plugin.SyncOptions
for scheduleropts.SchedulerOpts()
helper to convert plugin.SyncOptions
for scheduler
🤖 I have created a release *beep* *boop* --- ## [4.64.0](v4.63.0...v4.64.0) (2024-10-01) ### Features * Add `opts.SchedulerOpts()` helper to convert `plugin.SyncOptions` for scheduler ([#1900](#1900)) ([242fb55](242fb55)) * **remoteoauth:** Add `WithToken` option ([#1898](#1898)) ([ff7a485](ff7a485)) * Update concurrency formula. ([#1907](#1907)) ([adce99c](adce99c)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#1903](#1903)) ([ce2a0ef](ce2a0ef)) * **deps:** Update aws-sdk-go-v2 monorepo ([#1908](#1908)) ([bea3b00](bea3b00)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.22.4 ([#1912](#1912)) ([c28aabe](c28aabe)) * **deps:** Update module golang.org/x/oauth2 to v0.23.0 ([#1910](#1910)) ([6fe6414](6fe6414)) * **deps:** Update module google.golang.org/grpc to v1.67.0 ([#1904](#1904)) ([a349812](a349812)) * **deps:** Update opentelemetry-go monorepo ([#1911](#1911)) ([78e05e1](78e05e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.