feat: Add opts.SchedulerOpts() helper to convert plugin.SyncOptions for scheduler
#1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Sep 19, 2024
plugin/plugin_source.go
Outdated
| @@ -6,6 +6,7 @@ import ( | |||
|
|
|||
| "github.com/cloudquery/plugin-sdk/v4/glob" | |||
| "github.com/cloudquery/plugin-sdk/v4/message" | |||
| "github.com/cloudquery/plugin-sdk/v4/scheduler" | |||
There was a problem hiding this comment.
Unsure if it's worth the extra import. This is the only line in the plugin package to refer to scheduler.
There was a problem hiding this comment.
We can put this here https://github.com/cloudquery/plugin-sdk/tree/main/helpers
There was a problem hiding this comment.
scheduler already imports helpers (DFS uses helpers.InterfaceSlice() so it has to be a separate package. opts package, func SchedulerOpts()? (done in 77daaf3)
There was a problem hiding this comment.
forgot to git add, sorry fixed in 4d699f5
disq
changed the title
SchedulerOptions() helper method to plugin.SyncOptionsopts.SchedulerOpts() helper method to convert plugin.SyncOptions for scheduler
disq
changed the title
opts.SchedulerOpts() helper method to convert plugin.SyncOptions for scheduleropts.SchedulerOpts() helper to convert plugin.SyncOptions for scheduler
erezrokah
approved these changes
Sep 19, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
🤖 I have created a release *beep* *boop* --- ## [4.64.0](v4.63.0...v4.64.0) (2024-10-01) ### Features * Add `opts.SchedulerOpts()` helper to convert `plugin.SyncOptions` for scheduler ([#1900](#1900)) ([242fb55](242fb55)) * **remoteoauth:** Add `WithToken` option ([#1898](#1898)) ([ff7a485](ff7a485)) * Update concurrency formula. ([#1907](#1907)) ([adce99c](adce99c)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#1903](#1903)) ([ce2a0ef](ce2a0ef)) * **deps:** Update aws-sdk-go-v2 monorepo ([#1908](#1908)) ([bea3b00](bea3b00)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.22.4 ([#1912](#1912)) ([c28aabe](c28aabe)) * **deps:** Update module golang.org/x/oauth2 to v0.23.0 ([#1910](#1910)) ([6fe6414](6fe6414)) * **deps:** Update module google.golang.org/grpc to v1.67.0 ([#1904](#1904)) ([a349812](a349812)) * **deps:** Update opentelemetry-go monorepo ([#1911](#1911)) ([78e05e1](78e05e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.