Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: admin summary cannot be cached in redis #1329

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

topjohncian
Copy link
Member

Summary in admin dashboard caching was introduced in 0c9383.
It calls cache.Set function but doesn't handle errors.

If the user enables Redis, it won't successfully set cache because the type of the value cannot be serialized using gob, which is map[string]interface{}

So, we registered the types and fixed that.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1329 (1e8b991) into master (21d2b81) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   89.30%   89.33%   +0.03%     
==========================================
  Files          95       95              
  Lines        8272     8272              
==========================================
+ Hits         7387     7390       +3     
+ Misses        724      721       -3     
  Partials      161      161              
Impacted Files Coverage Δ
pkg/cluster/pool.go 85.34% <0.00%> (-9.49%) ⬇️
pkg/mq/mq.go 94.11% <0.00%> (-1.48%) ⬇️
pkg/task/pool.go 100.00% <0.00%> (+48.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d2b81...1e8b991. Read the comment docs.

@HFO4 HFO4 merged commit 25d56fa into cloudreve:master Jun 14, 2022
@HFO4
Copy link
Member

HFO4 commented Jun 14, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants