Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to remove frontend map files #1380

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Conversation

AH-dark
Copy link
Contributor

@AH-dark AH-dark commented Jul 2, 2022

Create-React-App uses the GENERATE_SOURCEMAP variable to control whether to generate map files, the default is true.

We can set it to false to avoid the generation of map files and the presence of map files in js files, which can avoid many warning events generated by the browser console because the map file cannot be found.

Copy link
Member

@HFO4 HFO4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make same changes in Dockerfile?

@AH-dark
Copy link
Contributor Author

AH-dark commented Jul 7, 2022

Can we make same changes in Dockerfile?

I'm done, please check.

@AH-dark AH-dark requested a review from HFO4 July 7, 2022 12:54
@HFO4 HFO4 merged commit c99b36f into cloudreve:master Jul 12, 2022
@HFO4
Copy link
Member

HFO4 commented Jul 12, 2022

Merged, Thanks!

@AH-dark
Copy link
Contributor Author

AH-dark commented Jul 12, 2022

horayyyy! my first pull request has been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants