-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added same-site
policy for session options
#1381
Conversation
AH-dark
commented
Jul 2, 2022
same-site
policy for session options
Why do we need this? Smaesite=None requires HTTPS to work, this will break some existing user's application. |
You are right, there is such a problem. Maybe we can add a configuration to the conf file for this? |
Yes, sounds good to me. |
So should I put it in the CORS section or open a new section? How do you think it should be? |
I think under CORS section is good. |
…nd `Secure` value of the session.
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
+ Coverage 89.27% 89.35% +0.08%
==========================================
Files 96 96
Lines 8306 8323 +17
==========================================
+ Hits 7415 7437 +22
+ Misses 727 723 -4
+ Partials 164 163 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I have finished adding the relevant configuration. By the way, I just learned that the See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie |
@HFO4 Sir, you haven't given me an answer yet! |
There seems to be conflict in |
Solved. |
Thanks! |