Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated isort from 5.10.1 to 5.11.5 and removed nb-black #71

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

martinjanssens
Copy link
Collaborator

@martinjanssens martinjanssens commented Aug 14, 2023

To allow pre-commit to continue functioning. Could have gone for an update to 5.12.0, but that would remove support for Python 3.7. Going that far might better be part of a bigger update?

This PR also comments nb-black from the testing, since it does not currently work (see dnanhkhoa/nb_black#40).

@leifdenby
Copy link
Collaborator

Looks great, thanks!

@martinjanssens martinjanssens merged commit 957ffa7 into cloudsci:master Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants