Upgrade to dj-stripe 1.1.1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….7.x"" This reverts commit c3a2e95.
Fixes a test error on Django master Refs. django/django@b3cffde
Django 2.2 compatibility Refs django/django@1e81a4b
This allows using a different API base host for development purposes. For example: https://github.com/stripe/stripe-mock
CLoses dj-stripe#534 Supercedes dj-stripe#594
Fixes issues on stripe>=2.0 (cherry picked from commit cf70c05)
Fixes issues on stripe>=2.0 (cherry picked from commit 23fec03)
Works around an issue in stripe-python 2.0 and pip. Context: stripe/stripe-python#447
AndrewSpeed
force-pushed
the
upgrade-to-dj-stripe-1-1-1
branch
from
9301d34
to
feb339d
Compare
apoclyps
reviewed
Nov 27, 2020
| Backwards-incompatible changes and deprecations | ||
| ----------------------------------------------- | ||
|
|
||
| Removal of polymorphic models |
There was a problem hiding this comment.
Flagging Backwards-incompatible changes and deprecations for folks to easily spot it during the review.
Do we extend any of these models in any way?
There was a problem hiding this comment.
No, the only references to the stripe polymorphic models provided by djstripe.stripe_objects that I could find were in documentation references in cloudsmith/core/billing/plans.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
As part of the process to upgrade
dj-stripeto it's latest version, we'll need to migrate to version1.1.xfirst, as1.2.0resets thedj-stripemigration numbering.This PR updates our fork to version
1.1.1so that we can run the necessary migrations on staging and production before migrating to1.2.0while maintaining our additional commit which fixes webhook atomicity, which gets addressed in the main repository in version2.0.3.