Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit a comment after the last semicolon #154

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Permit a comment after the last semicolon #154

merged 1 commit into from
Apr 12, 2023

Conversation

apstndb
Copy link
Collaborator

@apstndb apstndb commented Apr 12, 2023 •
edited
Loading

This PR fixes a bug introduced by #150.

Intended behavior

Valid because of a comment after the last semicolon.

SELECT 1; /* comment */

Invalid because empty statements terminated by semicolons are not permitted.

SELECT 1; /* comment */; SELECT 2

fixes #153

@apstndb apstndb requested a review from yfuruyama April 12, 2023 15:42
yfuruyama
yfuruyama approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@yfuruyama yfuruyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@yfuruyama yfuruyama merged commit a80699f into master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfuruyama yfuruyama yfuruyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executing statement followed by comment fails, which seems a bug
2 participants
@apstndb @yfuruyama