Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to make ID of root line empty in EXPLAIN and EXPLAIN ANALYZE #71

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Fix to make ID of root line empty in EXPLAIN and EXPLAIN ANALYZE #71

merged 2 commits into from
Jun 21, 2020

Conversation

apstndb
Copy link
Collaborator

@apstndb apstndb commented Jun 21, 2020 •
edited
Loading

ID of the root line shows 0 but it is wrong.

$ spanner-cli -e "EXPLAIN SELECT 1" -t
+----+-------------------------------------+
| ID | Query_Execution_Plan (EXPERIMENTAL) |
+----+-------------------------------------+
|  0 | .                                   |
|  0 | +- Serialize Result                 |
|  1 |     +- Unit Relation                |
+----+-------------------------------------+

Expected result is

$ spanner-cli -e "EXPLAIN SELECT 1" -t
+----+-------------------------------------+
| ID | Query_Execution_Plan (EXPERIMENTAL) |
+----+-------------------------------------+
|    | .                                   |
|  0 | +- Serialize Result                 |
|  1 |     +- Unit Relation                |
+----+-------------------------------------+

(It can implemented like ID: -1 rather than TextOnly: true but I don't want to add another meaning to ID field.)

@googlebot googlebot added the cla: yes CLA signed label Jun 21, 2020
yfuruyama
yfuruyama approved these changes Jun 21, 2020
View reviewed changes
Copy link
Collaborator

@yfuruyama yfuruyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yfuruyama yfuruyama merged commit face272 into cloudspannerecosystem:master Jun 21, 2020
@apstndb apstndb deleted the feature/fix-empty-id branch June 21, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfuruyama yfuruyama yfuruyama approved these changes

Assignees
No one assigned
Labels
cla: yes CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apstndb @yfuruyama @googlebot