fixes #27 – remove entity context for a cancelled stream.

[marcellanz]

Fixes #27 – "Entity throws error after 30 seconds of inactivity".

Please find a detailed analysis and script to reproduce the issue on the issue itself.

• the fix is valid for v0.1.0 and we'll release v0.1.1. The next milestone release will handle the entity context differently and this fix will not apply for the work currently done on the crdt branch which is the basis for milestone v0.2.0.
• Entity throws error after 30 seconds of inactivity #27 lists a shell script where the fix can be validated.
• a TCK image for v0.1.1 is already pushed to docker hub for verification.

[codecov-commenter]

Codecov Report

Merging #28 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   45.62%   45.39%   -0.24%     
==========================================
  Files           9        9              
  Lines         572      575       +3     
==========================================
  Hits          261      261              
- Misses        266      269       +3     
  Partials       45       45              

Impacted Files	Coverage Δ
cloudstate/cloudstate.go	30.17% <ø> (ø)
cloudstate/eventsourced.go	44.55% <0.00%> (-0.68%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd8eb4...177f7b3. Read the comment docs.

[pvlugter]

LGTM. Sounds good to have a quick fix now and the proper handling added to 0.2. Good to see the explanation and test in the issue.

[ralphlaude]

@marcellanz i have no idea on Go, but i see the context is deleted. Cool with the quick fix. It looks good.

[marcellanz]

i have no idea on Go, but i see the context is deleted. Cool with the quick fix. It looks good.

For sure a quick fix @ralphlaude for a dirty bug. But as I've mentioned, the rewrite done for the coming release with the CRDT support will have removed that global state, and also rewritten a few other not so clean things.

[marcellanz]

thanks for the review @pvlugter & @ralphlaude