Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Change Sets for stack upgrades #195

Closed
danielkza opened this issue Aug 19, 2016 · 4 comments
Closed

Support Change Sets for stack upgrades #195

danielkza opened this issue Aug 19, 2016 · 4 comments

Comments

@danielkza
Copy link
Contributor

danielkza commented Aug 19, 2016

Change Sets are a very useful AWS feature to evaluate modifications before a stack upgrade, and would fit quite well with most stacker workflows.

It would be nice if they were supported. They could be integrated into the build command, by creating change sets instead of directly applying changes, or into the diff command, by showing the change set description instead of just the template modifications.

(I plan to work on this on the near future, if nobody already does or plans to)

@danielkza danielkza changed the title Suppor Change Sets for stack upgrades Support Change Sets for stack upgrades Aug 19, 2016
@phobologic
Copy link
Member

Hey @danielkza - change set support was just added, though it's not in a release yet (I hope to have a release ready soon, in the next week most likely): #178

@danielkza
Copy link
Contributor Author

I was using the latest version from pip and missed the PR. Really great to know, I'll test it out ASAP. Sorry for the bogus report!

@phobologic
Copy link
Member

No worries! This release is long overdue, but we had a bunch of cool stuff coming in, so I've been holding off :) If you have any comments/concerns/suggestions for the way it's implemented, please let us know.

One thing to keep in mind is that it's hard to implement a diff command in changesets when you're dealing with multiple stacks, which is why @mhahn opted for the 'interactive build' model. Basically because if Stack B is pulling an output from Stack A, you can't know that STack B has changed till you see what happens with Stack A (at least not in anyway that I can imagine).

Anyway, thanks for giving it a try! Let us know how it goes :)

@danielkza
Copy link
Contributor Author

danielkza commented Aug 21, 2016

I just figured out why I thought I was up-to-date but was not: I first installed stacker by simply having stacker in requirements.txt, then tried upgrading to a local copy using pip install -e. It didn't work as expected because the version number didn't change, causing pip to not actually link the stacker script to the new copy.

I believe always bumping the version in master right after a release would solve it. For example, if the current master is released as 0.7.0, then right afterwards the version should be bumped to 0.7.1.dev0, 0.8.0.dev0 or something like that, according to PEP440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants