Initial pass at interactive aws provider #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated this a little bit: I'm going to implement some alternative outputs, but I'll do them in a separate PR since the core of this one should just be the implementation of the interactive provider. Now you can specify Right now interactive builds display each change set. I'm going to change this in a separate PR so by default we only display when the change set requires a replacement. I'll then add a |
|
https://github.com/mhahn/stacker/pull/1/files I'll submit that against this one when this is merged. Adds the "verbose" option that you had mentioned. By default we'll only list out the replacements, but you can provide "v" to list out all the changes: |
Closed
| @@ -242,6 +246,9 @@ def execute(self): | |||
| if attempts == 1: | |||
| self._check_point() | |||
| self._wait_func(self.sleep_time) | |||
| except CancelExecution: | |||
| logger.info("Cancelling execution") | |||
There was a problem hiding this comment.
Worth including the plan step here?
There was a problem hiding this comment.
i'll keep this in mind, i might make some changes to the output, i'll take a look at this then
|
Looks good other than my comments, thanks. |
|
|
||
| from ... import exceptions | ||
| from .default import ( | ||
| Provider as BaseProvider, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge, but wanted to get it out there to start some discussion around the output:
Right now it looks like:
I'm going to play with some cli libraries to see if I can come up with something cleaner.