Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a slash inside a lookup seems to cause infinite recursion #213

Closed
ttarhan opened this issue Sep 1, 2016 · 2 comments
Closed

Having a slash inside a lookup seems to cause infinite recursion #213

ttarhan opened this issue Sep 1, 2016 · 2 comments

Comments

@ttarhan
Copy link
Contributor

ttarhan commented Sep 1, 2016

While working in the ${file...} lookup, I discovered that having a slash inside the lookup, such as:

${file parameterized-b64:file://userdata.txt}

causes infinite recursion in Variable.resolve, on line 118 (while self.lookups). Simply removing the slashes in the path above avoids the problem.

I haven't looked into the root cause yet.

@phobologic
Copy link
Member

I'm taking a guess, but it's likely due to this line: https://github.com/remind101/stacker/blob/master/stacker/variables.py#L11 - you might need to include \/ in the idpattern. @mhahn will know best.

@ttarhan
Copy link
Contributor Author

ttarhan commented Sep 1, 2016

@phobologic indeed, that fixes it. I'll put in a simple PR just for that fix right now.

mwildehahn added a commit that referenced this issue Sep 1, 2016
Resolves issue #213 - slashes inside variable lookups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants