Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit/default lookup pointing at output #298

Closed
phobologic opened this issue Jan 18, 2017 · 1 comment
Closed

Remove explicit/default lookup pointing at output #298

phobologic opened this issue Jan 18, 2017 · 1 comment
Milestone

Comments

@phobologic
Copy link
Member

Right now if you don't specify the lookup you're using, it'll default to output, as detailed here: http://stacker.readthedocs.io/en/latest/lookups.html

After a chat in the Slack, folks seemed to agree that this shortcut wasn't necessary, and could lead to confusion and/or other issues. It also complicates the code a bit.

To do that, the plan is to remove this feature in 1.0.

@phobologic phobologic added this to the 1.0 milestone Jan 18, 2017
phobologic added a commit that referenced this issue Jan 29, 2017
This removes the old functionality where if a lookup was called, but no
lookup handler was given, it would default to using `output`.  IE:

```
SomeVariable: ${vpc::PublicSubnets}
```

must now explicitly call to the output lookup handler:

```
SomeVariable: ${output vpc::PublicSubnets}
```

Fixes #298
phobologic added a commit that referenced this issue Jan 29, 2017
This removes the old functionality where if a lookup was called, but no
lookup handler was given, it would default to using `output`.  IE:

```
SomeVariable: ${vpc::PublicSubnets}
```

must now explicitly call to the output lookup handler:

```
SomeVariable: ${output vpc::PublicSubnets}
```

Fixes #298
This was referenced Feb 4, 2017
@phobologic
Copy link
Member Author

Fixed in #310

phrohdoh pushed a commit to phrohdoh/stacker that referenced this issue Dec 18, 2018
This removes the old functionality where if a lookup was called, but no
lookup handler was given, it would default to using `output`.  IE:

```
SomeVariable: ${vpc::PublicSubnets}
```

must now explicitly call to the output lookup handler:

```
SomeVariable: ${output vpc::PublicSubnets}
```

Fixes cloudtools#298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant