Convert KMS translator to a Lookup #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just off the top of my head, lets not remove the translator right away. We should keep it around, and slowly migrate away from the old syntax to the new. |
|
yea, probably a good call |
|
👍 looks good, looks like there's a conflict from other changes, can you refresh it and deal with the conflicts, and then go ahead and merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the KMS translator to a Lookup.
This changes the syntax for referencing
kmsencrypted values within environment & configs, instead ofconf_value: !kms <encrypted value>you should use the new lookup syntax:conf_value: ${kms <encrypted value>}.