Remove transformation of variables #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops the type checker from transforming variables, making it more strict. Magically changing the variable type was a little janky to begin with, so I think this is the right thing to do. Should partially fix #255
|
@mhahn any thoughts on this? |
|
If we're going to do this, I think we should prevent any transformations of the variable. ie. |
|
Right now you could still transform the value with: https://github.com/remind101/stacker/pull/266/files#diff-9e12e7feca740fe22caedce88b419cbcR196 |
|
Ok, @mhahn, I think this should be good to go now. Let me know what you think. |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
…_typing Remove transformation of variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the type checker from transforming variables, making it more
strict. Magically changing the variable type was a little janky to begin
with, so I think this is the right thing to do.
Should partially fix #255