Remove --var flag #289
Merged
Remove --var flag #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--variables comes from the days when we didn't have environments, so the only way to change things between environments was to pass arguments on the command line. In general, environments are a better use case (reproducibility is much better) and continuing to support the CLI --var was getting difficult due to complex variable types. Removing for 1.0 after discussing on #stacker. If needed in the future, we can reconsider.
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Remove --var flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--variables comes from the days when we didn't have environments, so the
only way to change things between environments was to pass arguments on
the command line. In general, environments are a better use case
(reproducibility is much better) and continuing to support the CLI --var
was getting difficult due to complex variable types.
Removing for 1.0 after discussing on #stacker. If needed in the future,
we can reconsider.