-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DescribeStacks call from prepare_stack_for_update #529
Conversation
@danielkza since you originally added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - have you ran the integration tests? Probably worthwhile just in case.
@@ -694,7 +694,7 @@ def select_update_method(self, force_interactive, force_change_set): | |||
else: | |||
return self.default_update_stack | |||
|
|||
def prepare_stack_for_update(self, fqn, tags): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the docstring.
Yep, integration tests pass. |
7e6737b
to
7657f7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=========================================
- Coverage 88.63% 88.6% -0.03%
=========================================
Files 94 94
Lines 6000 5987 -13
=========================================
- Hits 5318 5305 -13
Misses 682 682
Continue to review full report at Codecov.
|
Remove DescribeStacks call from prepare_stack_for_update
This is a small performance optimization to remove an unnecessary DescribeStacks call from the
prepare_stack_for_update
method.Before this change, the outbound network calls for a single noop stack update would look like this:
The 3rd DescribeStacks (step 4) is unnecessary, and can be easily removed, since we already have a DescribeStacks response from the first call.