Add a --profile flag to specify default profile #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
approved these changes
Mar 15, 2018
stacker/session_cache.py
Outdated
| @@ -23,6 +25,9 @@ def get_session(region, profile=None): | |||
| :class:`boto3.session.Session`: A boto3 session with | |||
| credential caching | |||
| """ | |||
| if profile is None: | |||
| profile = default_profile | |||
|
|
|||
There was a problem hiding this comment.
Do you think it's worth adding a debug log in here so we can see what profiles/regions sessions are being created in?
|
Should we have some documentation about why this flag exists? Maybe in the flag help syntax itself? Also does it overwrite |
|
Good call. Extended the flag docs and added some debug logging to |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Add a --profile flag to specify default profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--profileflag, similar to the--regionflag that specifies a global default profile for stacker to use for all AWS API calls, when no explicitprofileis specified.Another way to do this is is to specify the
AWS_PROFILEorAWS_DEFAULT_PROFILEenvironment variable, but in certain configurations that won't actually work.