Add support for stack policies #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
approved these changes
Mar 19, 2018
stacker/providers/aws/default.py
Outdated
| @@ -414,6 +415,12 @@ def generate_cloudformation_args(stack_name, parameters, tags, template, | |||
| else: | |||
| args["TemplateBody"] = template.body | |||
|
|
|||
| if stack_policy: | |||
| if stack_policy.url: | |||
There was a problem hiding this comment.
Is this for future code, or am I misunderstanding? I don't see any mention of stack_policy.url in this PR.
There was a problem hiding this comment.
Also, can you throw some a debug statement or two in this block? That way we can see if someone is using a stack policy with -v
There was a problem hiding this comment.
Yeah, just for the future, in case we ever support uploading to S3 first. I'll add some debug statements to this.
There was a problem hiding this comment.
Can you throw a comment in there, just so that if someone sees this they aren't confused in the future?
ejholmes
force-pushed
the
stack-policies
branch
from
f04bb9c
to
99e6b99
Compare
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Add support for stack policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112
This is something I've wanted for a long time. Stack policies are a great way to add an extra layer of protection around sensitive resources, like databases, VPC subnets, etc.
It's entirely possible to make use of stack policies outside of stacker (we have for some time now), but it ends up being pretty manual. It'd be great to be able to automate it with stacker.