-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targets #572
Conversation
8a17dbe
to
43e686d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - you have any more work on this, @ejholmes, or is it ready to go in? I'm thinking we should be looking at a 1.3.1 release soon, or possibly 1.4 since there's quite a bit of good stuff already in master.
I don't have much that I want to add to this, but don't necessarily want to merge it until we've got a chance to use it at Remind. |
This would be very useful to help integrate hooks with the DAG, which is something I'm currently looking into. I can do some manual testing to help out, anything in particular you are looking for @ejholmes ? |
Nothing in particular, just some normal testing/feedback. I just rebased this on top of master if you decide you want to try it. |
a267bac
to
ca34622
Compare
Well, it's broken against master. I'll take a look at updating this soon. |
This adds "targets" to stacker, which are just named nodes in the graph that specify dependencies. Why would you want this? Primarily just as an easy way to specify a logical grouping of stacks that you can use with the --targets flag (e.g. maybe you want a target for "databases" or "apps", etc). Essentially, these are no different than stacks, except they don't incur any AWS API calls, and don't take up a precious CloudFormation stack spot. If you're familiar with targets in systemd, the concept is exactly the same; a node in the graph that does nothing.
Rebased this on top of master, and fixed the breakage (minor change to stacker/actions/graph.py). This is working nicely for us at Remind, so I'll merge for inclusion in the 1.5 release. |
This adds "targets" to stacker, which are just named nodes in the graph that specify dependencies.
Why would you want this? Primarily just as an easy way to specify a logical grouping of stacks that you can use with the
--targets
flag (e.g. maybe you want a target for "databases" or "apps", etc). Essentially, these are no different than stacks, except they don't incur any AWS API calls, and don't take up a precious CloudFormation stack spot.If you're familiar with targets in systemd, the concept is exactly the same; a node in the graph that does nothing.