Run dump and outline actions offline #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build does not need access to AWS when run with `dump` or `outline` options so make it run offline for those actions.
zaro0508
commented
May 9, 2018
| bool: If access to CF bucket is needed, return True. | ||
|
|
||
| """ | ||
| return outline is False and dump is False |
There was a problem hiding this comment.
may need to consider package sources as well. if user sets up package sources then I think stacker needs to run in online mode.
phobologic
approved these changes
May 12, 2018
phobologic
added a commit
that referenced
this pull request
May 13, 2018
594 assumed that `dump` would use `False` as it's default, but since `--dump` is a `str` type, it instead uses `None` when it is not specified on the CLI. The truth is that this is more pythonic anyway, and has the same effect. I can't imagine when this could cause un-expected behaivior.
phobologic
added a commit
that referenced
this pull request
May 14, 2018
594 assumed that `dump` would use `False` as it's default, but since `--dump` is a `str` type, it instead uses `None` when it is not specified on the CLI. The truth is that this is more pythonic anyway, and has the same effect. I can't imagine when this could cause un-expected behaivior.
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
Build does not need access to AWS when run with `dump` or `outline` options so make it run offline for those actions.
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
594 assumed that `dump` would use `False` as it's default, but since `--dump` is a `str` type, it instead uses `None` when it is not specified on the CLI. The truth is that this is more pythonic anyway, and has the same effect. I can't imagine when this could cause un-expected behaivior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build does not need access to AWS when run with
dumporoutlineoptions so make it run offline for those actions.