allow raw cfn templates to be loaded from remote package_sources #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - can you provide some tests @troyready ? |
troyready
force-pushed
the
add_raw_templates_in_remote_pkgs
branch
from
627f5a1
to
dd13b0f
Compare
|
@phobologic sure thing; added |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
…udtools#638) * allow raw cfn templates to be loaded from remote package_sources Fixes cloudtools#628 * add test for new get_template_path function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
This will be backwards compatible with any existing deployments, and should provide the expected load order for any more advanced use. Also gives a nicer error message now on filename typos.